Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass context from Reconcile function to inside functions #44

Merged
merged 1 commit into from
Apr 19, 2023
Merged

Pass context from Reconcile function to inside functions #44

merged 1 commit into from
Apr 19, 2023

Conversation

itamar-marom
Copy link
Collaborator

Fixes #43

Description

Instead of using context.TODO() which is used for development, we will pass the Reconcile function context is describe in Kubebuilder's documentation

This PR has:

  • been tested on a real K8S cluster to ensure creation of a brand new Druid cluster works.
  • been tested for backward compatibility on a real K*S cluster by applying the changes introduced here on an existing Druid cluster. If there are any backward incompatible changes then they have been noted in the PR description.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.
Key changed/added files in this PR
  • controllers/druid/druid_controller.go
  • controllers/druid/handler.go

@AdheipSingh AdheipSingh merged commit 2a5d9f5 into datainfrahq:master Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdheipSingh AdheipSingh AdheipSingh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Context is not being passed through functions
2 participants
@itamar-marom @AdheipSingh